feat: initial job property validation docs#915
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdates the job specification documentation by adding a title annotation to the YAML example. Replaces the previous property-field explanation with a property validation section covering BOSH version requirements, Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@content/jobs.md`:
- Around line 111-112: Insert a blank line between the `---` separator and the
`## Property validation` heading in the property-validation section, preserving
the heading and separator unchanged.
- Around line 132-139: Update the trusted_certificate property in
properties-schema.json to use the valid JSON Schema type "string" instead of
"certificate"; preserve any certificate-specific requirements through separate
validation or description metadata.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4fbd9741-2a4a-4ea1-b892-432454065c91
📒 Files selected for processing (1)
content/jobs.md
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
5fc610d to
afcdff8
Compare
Document BOSH release job property validation see: cloudfoundry/community#1049 see: cloudfoundry/bosh-cli#681 see: cloudfoundry/bosh#2602 Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
afcdff8 to
cc69f46
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Pull request overview
Documents BOSH release job property validation by introducing a new “Property validation” section in the release jobs documentation, including version requirements and example JSON Schemas.
Changes:
- Adds a dedicated “Property validation” section describing how job properties can be validated via JSON Schema.
- Includes example schema files and a BOSH-specific JSON Schema
certificatetype extension. - Improves/clarifies existing wording around job spec property keys and validation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
57ca4c9
aramprice
moved this from Pending Merge | Prioritized
to Waiting for Changes | Open for Contribution
in Foundational Infrastructure Working Group
|
@achrinza - could you rebase this, there appear to be conflicts. Thanks! |
Document BOSH release job property validation
see: cloudfoundry/community#1049
see: cloudfoundry/bosh-cli#681
see: cloudfoundry/bosh#2602